fix: refix tokenizer with added token shenanigans#304
Open
stephantul wants to merge 2 commits intoMinishLab:mainfrom
Open
fix: refix tokenizer with added token shenanigans#304stephantul wants to merge 2 commits intoMinishLab:mainfrom
stephantul wants to merge 2 commits intoMinishLab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the tokenizer AGAIN by
[MASK]for bert models. This solved a bug with some tokenizers having added tokens that were out of bounds.I had to update a whole bunch of tests. The vocabulary counts are different because we now also remove any special tokens we used to keep, such as
[EOS]. The only special tokens we now keep are the ones actually relevant to model2vec, which are the padding token (which is now set correctly) and the unk token.NB: tests will fail because of
utils.py