Preserve user-entered IDN addresses for display - #1203
Open
chiphead2332 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Preserve the user-entered internationalized domain name (IDN) as the server's display address while continuing to use its ASCII/Punycode form for network requests.
This allows addresses such as
https://bücher.deto remain recognizable in Moonfin's UI instead of being replaced byhttps://xn--bcher-kva.deafter normalization or connection.Related Issues
Type of Change
Changes Made
Platform
Testing
The change was validated with automated formatting, static analysis, targeted regression tests, the adjacent add-server UI test, and manual testing on Windows.
Test Steps
xn--...form.Screenshots (if applicable)
Not applicable.
Checklist