Skip to content

dont preserve sidebar on screens that should hide it - #256

Merged
RadicalMuffinMan merged 1 commit into
Moonfin-Client:masterfrom
jmawet:sidebar-hide
Sep 3, 2026
Merged

dont preserve sidebar on screens that should hide it#256
RadicalMuffinMan merged 1 commit into
Moonfin-Client:masterfrom
jmawet:sidebar-hide

Conversation

@jmawet

@jmawet jmawet commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

Sidebar was showing on the library screens. Reverted that so it hides just like on other clients.

Related Issues

Link related issues or tickets separated by commas.

  • Closes #
  • Fixes #
  • Related to #

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

List the key changes included in this PR.

  • remove the "or sidebar" part of the visibility determination so sidebar isn't forced to stay on all screens

Testing

Describe how this change was tested.

  • Tested on physical Roku device
  • Tested via sideload
  • Manual testing completed
  • Not tested (explain why):

Test Steps

Screenshots (if applicable)

Before:
image

After:
image

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

@RadicalMuffinMan
RadicalMuffinMan merged commit 805c203 into Moonfin-Client:master Sep 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants