Skip to content

fix(search): improve focus navigation and row scrolling - #394

Merged
RadicalMuffinMan merged 2 commits into
Moonfin-Client:mainfrom
wmurphy126:fix/search-focus-and-scrolling
Aug 28, 2026
Merged

fix(search): improve focus navigation and row scrolling#394
RadicalMuffinMan merged 2 commits into
Moonfin-Client:mainfrom
wmurphy126:fix/search-focus-and-scrolling

Conversation

@wmurphy126

Copy link
Copy Markdown

Pull Request

Summary

Improves remote navigation and layout behavior in Search. The selected category is restored when leaving results, the search field shows its themed focus state, the collapsed left navigation no longer overlaps content, and the final result card scrolls fully onscreen.

Related Issues

None.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

  • Return upward navigation to the currently selected search category.
  • Add theme-aware search-field focus styling and collapsed-sidebar spacing.
  • Correct result-row scrolling and provide sufficient edge space for focused cards.

Platform

  • Tizen (Samsung)
  • webOS (LG)
  • Both / Shared code

Testing

  • Tested on emulator
  • Tested on physical device
  • Manual testing completed
  • Not tested (explain why):

Tested on an LG webOS TV.

Test Steps

  1. Search for a term with results across multiple categories.
  2. Navigate between the search field, category tabs, and result rows.
  3. Navigate to the final item in a full result row and confirm the focused card remains fully visible.

Screenshots (if applicable)

N/A.

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown

✅ Build Successful

All platform builds passed. You can download the test artifacts below.

Platform Status Artifact
webOS ✅ Passed Moonfin_webOS_*.ipk
Tizen Regular ✅ Passed Moonfin_Tizen_Regular_*.wgt
Tizen Oblong ✅ Passed Moonfin_Tizen_Oblong_*.wgt
Tizen Legacy ✅ Passed Moonfin_Tizen_Legacy_*.wgt
Property Value
Commit 9d162ab
Workflow run Build #242

…ating it

The search offset hardcoded the collapsed sidebar width while the sidebar declared its own copy, so the two could drift apart. Both read the same variable now.

The row scroller asked for an overflow-y of visible next to an overflow-x of auto, which computes to auto regardless, so the declaration described something that never happened
@RadicalMuffinMan
RadicalMuffinMan merged commit 271f8ae into Moonfin-Client:main Aug 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants