fix: validation module hardening — false negatives, crash, silent fallbacks#703
Merged
Conversation
…lbacks Static analysis (P0): - schema_extractor: remove wrong top-level observe/drops reads that produced empty sets — context_scope reads below already handle this. Add warning if user puts these keys at top level instead of under context_scope. Crash fix (P0): - key_verifier: catch TimeoutError from as_completed() and collect completed-but-unconsumed futures instead of crashing preflight Silent fallback (P1): - resolution_service: narrow except Exception to specific types (FileNotFoundError, OSError, ValueError, YAMLError), escalate to warning. Remove false docstring promise about format-mismatch warnings. Dead validator (P1): - workflow_static_analyzer: wire check_missing_dependencies() into analyze() — implicit dependency bugs now caught statically UX (P3): - granularity_output_field_validator: improve error message to tell user to add json_mode: false
…cept clause - schema_extractor: remove spurious warning for top-level observe/drops keys — these are valid ActionConfig fields, not misplaced context_scope - resolution_service: restore except Exception for _resolve_prompt_for_extraction because PromptFormatter.get_raw_prompt wraps all errors in PromptValidationError which the narrowed tuple didn't catch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
observe/dropsreads that produced empty sets —context_scopereads already handle this correctly. Warn if user misplaces keys.TimeoutErrorfromas_completed()— collect completed-but-unconsumed futures, mark timed-out vendors as skippedexcept Exceptionto specific types, escalate to warning. Fix false docstring promise.check_missing_dependencies()intoanalyze()— implicit dependency bugs now caughtVerification
ruff check— cleanruff format --check— cleanpytest— 7494 passed, 2 skipped