upnp: allow 1.14.30#2448
Conversation
|
There is still no reply from upstream to my bug report: pupnp/pupnp#528 I don't understand your version_compare call. According to the Meson documentation, it allows only a single parameter: https://mesonbuild.com/Syntax.html#version_compare - but you pass three. What does that mean? |
PPN-SD
force-pushed
the
allow_1.14.30
branch
2 times, most recently
from
7d169b6 to
3d2ae5f
Compare
Two are allowed since meson-1.8. But maybe you won't up this for that.
Two bad pushes, sry. |
|
The stable branch (v0.24.x) must remain compatible with Meson 1.0. Your PR targets master - are you aware that this will not be part of the next bug-fix release then? |
And it should be compatible with GitHub Actions runner images - as you see in the build failure, it has only Meson 1.3.2. That is not the most important thing (because GitHub often lags behind more than even Debian), it's most important to be compatible with Debian Stable - Debian is a good benchmark for "builds everywhere (unless people are reaaaaaaally on old OS)". |
OK.
The most important thing is in my opinion to let the distributions apply version 1.14.30 and not directly block version >= 1.14.26. It doesn’t matter what happens to this PR, to be honest. |
Does this mean you don't want to fix this PR? |
PPN-SD
force-pushed
the
allow_1.14.30
branch
2 times, most recently
from
889ded3 to
171d112
Compare
|
It should be fine now. |
ABIbreak in 1.14.26 has been reverted w/ 1.14.30, reapplied in 1.18.X align with upstream versions and make easier packaging. Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>
2 participants
ABIbreak in 1.14.26 has been reverted w/ 1.14.30, reapplied in 1.18.X
align with upstream versions and make easier packaging.