Skip to content

fixing cable units bug from rotorD to km - #207

Open
gbarter wants to merge 1 commit into
developfrom
fix_cable_units
Open

fixing cable units bug from rotorD to km#207
gbarter wants to merge 1 commit into
developfrom
fix_cable_units

Conversation

@gbarter

@gbarter gbarter commented Jul 28, 2026

Copy link
Copy Markdown
Member

Purpose

Per error report via email, the cable length calculation was reported in km, but was computed in terms of number of rotor diameters and never scaled by rotor_diameter_m

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@gbarter
gbarter requested a review from RHammond2 July 28, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant