Fix: Correctly apply 6 decimal precision capacity verification - #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Correctly apply 6 decimal precision capacity verification
This PR updates the project capacity verification to correctly check with a 6 decimal precision to avoid floating point discrepancies. In addition, all error messages spanning multiple lines are now declared as a variable to simplify the stack trace for easier debugging.
PR Checklist
CHANGELOG.mdhas been updated to describe the changes made in this PRdocs/files are up-to-date, or added when necessaryRelated issues
N/A
Impacted areas of the software
wombat/core/simulation_api.py_setup_simulation: Updates the project capacity verification for an actual 6 digit precision check.Additional supporting information
Python version: 3.13.11
WOMBAT version (
wombat.__version__): 0.13The addition of the error message reformatting came about from a difficult to read traceback in a failed capacity verification.
Test results, if applicable
Tests pass.