Bug/1876 mom import failing#1880
Merged
Merged
Conversation
…ortStream Assets custom logic.
…unsubscribing before subscribing (-= OnLogMessage followed by += OnLogMessage).
- Removed the "Download Latest ZIP" button across all localized `index*.html` files. - Renamed the remaining Windows download button text to "Download Latest" (or its localized equivalent). - This ensures users default to downloading the `.exe` installer and reduces confusion, as users previously mistook the `.zip` download for a ZIP import file.
- Added filename validation to ensure users select the correct `.zip` file for the specific game (e.g. `ImportDesktop_Descent.zip` or `ImportAndroid_Descent.zip` for Descent). - Added an initial check to verify the ZIP archive contains the required `import.ini` file before extraction. - Introduced localized error messages (`ERROR_INVALID_ZIP_NAME`, `ERROR_MISSING_IMPORT_INI`) across all translation files to provide clear feedback when validation fails.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| using (ZipArchive archive = new ZipArchive(reader.BaseStream, ZipArchiveMode.Read)) | ||
| { | ||
| List<string> splitFiles = new List<string>(); | ||
| // register all files before parsing the assets so that the external references can be found |
…rity/code-scanning/2 >Arbitrary file access during archive extraction ("Zip Slip") Unsanitized archive entry, which may contain '..', is used in a file system operation. Unsanitized archive entry, which may contain '..', is used in a file system operation. Extracting files from a malicious zip file, or similar type of archive, is at risk of directory traversal attacks if filenames from the archive are not properly validated.
Quantumrunner
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.