Allowing top_p to be set as null#1044
Closed
Davood-M wants to merge 2 commits into
Closed
Conversation
added 2 commits
November 4, 2025 09:21
Signed-off-by: David Mosallanezhad <dmosallanezh@oci-nrt-cs-001-vscode-01.cm.cluster>
gwarmstrong
reviewed
Nov 19, 2025
Collaborator
gwarmstrong
left a comment
gwarmstrong
left a comment
There was a problem hiding this comment.
Looks good overall--please fix the failing check
Collaborator
|
just to update here, I have some WIP to generalize this change to all parameters, not just topp |
Collaborator
|
closing as this will be fixed with gym migration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this case, vllm will use the default top_p value from generation config of model