docs: add routing strategies table and the libsy library path - #331
Conversation
Signed-off-by: Ryan Lempka <rlempka@nvidia.com>
Signed-off-by: Ryan Lempka <rlempka@nvidia.com>
Signed-off-by: Ryan Lempka <rlempka@nvidia.com>
|
Signed-off-by: Ryan Lempka <rlempka@nvidia.com>
Signed-off-by: Ryan Lempka <rlempka@nvidia.com>
WalkthroughThe documentation adds direct Rust embedding through ChangesLibrary execution documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
README.md (1)
104-108: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winPin the library dependency source in both quick-start examples.
Both snippets resolve
switchyard-libsyandswitchyard-protocolfrom the moving default branch. Use the same published version or immutable commit in both files.
README.md#L104-L108: pin both Git dependencies or use published versions.docs/getting_started.md#L246-L253: apply the same pinned source and keep the two dependencies aligned.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` around lines 104 - 108, Pin both switchyard-libsy and switchyard-protocol dependencies in README.md lines 104-108 to the same published version or immutable commit. Apply the identical aligned pin to both dependencies in docs/getting_started.md lines 246-253.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/getting_started.md`:
- Around line 264-266: Update the escalation row in the route-strategy
documentation to include type = "llm_classifier" and mode = "escalation", and
identify escalation = { ... } as the optional configuration block.
In `@README.md`:
- Around line 110-111: Change the README sentence around the Getting Started
link to call the library-path section an “overview” rather than a “worked
example,” unless you add a minimal executable Rust flow demonstrating drive, the
host serve callback, and CallLlmRequest::respond.
---
Nitpick comments:
In `@README.md`:
- Around line 104-108: Pin both switchyard-libsy and switchyard-protocol
dependencies in README.md lines 104-108 to the same published version or
immutable commit. Apply the identical aligned pin to both dependencies in
docs/getting_started.md lines 246-253.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 2023ccc1-df58-4a6a-8d50-9e2f9fb3e066
📒 Files selected for processing (2)
README.mddocs/getting_started.md
Signed-off-by: Ryan Lempka <rlempka@nvidia.com>
Signed-off-by: Ryan Lempka <rlempka@nvidia.com>
Addressing some feedback on docs gaps.
Summary by CodeRabbit