Skip to content

docs(experimentalist): point the nooa pin at the file that actually has it - #1099

Merged
callingmedic911 merged 1 commit into
mainfrom
nooa-pin-docs-location/aditypandey
Aug 7, 2026
Merged

docs(experimentalist): point the nooa pin at the file that actually has it#1099
callingmedic911 merged 1 commit into
mainfrom
nooa-pin-docs-location/aditypandey

Conversation

@callingmedic911

@callingmedic911 callingmedic911 commented Aug 5, 2026

Copy link
Copy Markdown
Member

the nooa framework skill tells you to use the revision "pinned in pyproject.toml," but plugins/nemo-experimentalist/pyproject.toml declares a bare nooa with no revision.

The pin is in the workspace root pyproject.toml under [tool.uv.sources], which is where uv resolves workspace members from, and uv.lock pins the commit accordingly. So this is a docs pointer bug, not a missing pin.

Summary by CodeRabbit

  • Documentation
    • Updated NOOA dependency guidance to reference the workspace-root pinned revision.
    • Documented support for callable @strategy(llm=...) usage with newer NOOA revisions.
    • Clarified which related files must be updated together and where to review compatibility details.
    • Removed outdated references to the previous version and transport-timeout fix.

…as it

The nooa skill, README, and AGENTS.md all said the revision was pinned in
"pyproject.toml" without saying which one. Read from the plugin directory that
means plugins/nemo-experimentalist/pyproject.toml, which declares a bare `nooa`
— the pin lives in the workspace root [tool.uv.sources], where uv resolves
workspace members from.

Also correct the commit-not-tag rationale, which still cited an MCP
transport-timeout fix past v0.0.6 while the pinned commit is past v0.0.8, and
add the skill to the bump checklist so its two hardcoded SHAs stop drifting.

Signed-off-by: Aditya Pandey <aditypandey@nvidia.com>
@callingmedic911
callingmedic911 requested review from a team as code owners August 5, 2026 17:28
@github-actions github-actions Bot added the docs label Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8a783571-166b-46ea-80f1-ced8c058ab01

📥 Commits

Reviewing files that changed from the base of the PR and between 9b7f483 and 8a3a13d.

📒 Files selected for processing (3)
  • plugins/nemo-experimentalist/AGENTS.md
  • plugins/nemo-experimentalist/README.md
  • plugins/nemo-experimentalist/framework-skills/nooa/SKILL.md

📝 Walkthrough

Walkthrough

The Experimentalist documentation now references the workspace-root nooa revision, requires post-v0.0.8 callable @strategy(llm=...) support, and updates framework setup guidance.

Changes

Experimentalist nooa documentation

Layer / File(s) Summary
Workspace pin and compatibility guidance
plugins/nemo-experimentalist/AGENTS.md, plugins/nemo-experimentalist/README.md, plugins/nemo-experimentalist/framework-skills/nooa/SKILL.md
Documentation identifies the workspace-root dependency pin, updates the required nooa revision, and aligns framework-specific setup guidance.

Possibly related PRs

Suggested reviewers: aleckhoury, tylersbray, anubhutivyas

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main documentation change: pointing the nooa pin reference to the workspace-root file that defines it.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nooa-pin-docs-location/aditypandey

Comment @coderabbitai help to get the list of available commands.

@gabwow gabwow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@callingmedic911
callingmedic911 added this pull request to the merge queue Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 30743/39237 78.3% 62.7%
Integration Tests 18062/37189 48.6% 21.0%

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 5, 2026
@callingmedic911
callingmedic911 added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit af733af Aug 7, 2026
56 checks passed
@callingmedic911
callingmedic911 deleted the nooa-pin-docs-location/aditypandey branch August 7, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants