fix(studio): SliderWithTextInput doesn't accept out of range partial inputs - #1111
Open
steramae-nvidia wants to merge 1 commit into
Open
fix(studio): SliderWithTextInput doesn't accept out of range partial inputs#1111steramae-nvidia wants to merge 1 commit into
steramae-nvidia wants to merge 1 commit into
Conversation
…inputs Signed-off-by: Sean Teramae <steramae@nvidia.com>
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
Contributor
📝 WalkthroughWalkthroughChangesNumeric input handling
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
web/packages/common/src/components/SliderWithTextInput/index.tsx (1)
19-19: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse
import typefor type-only symbols.
ComponentPropsandReactNodeare only used as types.Proposed fix
-import { ComponentProps, ReactNode, useState } from 'react'; +import { useState } from 'react'; +import type { ComponentProps, ReactNode } from 'react';As per coding guidelines, “Use
import typefor type-only imports.”🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/common/src/components/SliderWithTextInput/index.tsx` at line 19, Update the import in the SliderWithTextInput component so ComponentProps and ReactNode are imported with import type, while keeping useState as the regular runtime import.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/common/src/components/SliderWithTextInput/index.tsx`:
- Around line 84-95: The handleTextInputBlur function must not invoke
attributes?.Slider?.onValueChange?. Remove that callback invocation while
preserving the existing parsing, clamping, equality check, and field.onChange
behavior; text-input updates should continue through the TextInput callback
path.
---
Nitpick comments:
In `@web/packages/common/src/components/SliderWithTextInput/index.tsx`:
- Line 19: Update the import in the SliderWithTextInput component so
ComponentProps and ReactNode are imported with import type, while keeping
useState as the regular runtime import.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1425855e-89e1-46be-bb94-3f9876eff086
📒 Files selected for processing (3)
web/packages/common/src/components/ModelSelectV2/InferenceParameters.test.tsxweb/packages/common/src/components/SliderWithTextInput/SliderWithTextInput.test.tsxweb/packages/common/src/components/SliderWithTextInput/index.tsx
Comment on lines
+84
to
95
| const handleTextInputBlur = (event: React.FocusEvent<HTMLInputElement>) => { | ||
| const rawValue = draftValue; | ||
| setDraftValue(null); | ||
| attributes?.TextInput?.onBlur?.(event); | ||
| if (rawValue === null || rawValue === '') return; | ||
| const numberValue = parseFloat(rawValue); | ||
| if (Number.isNaN(numberValue)) return; | ||
| const clampedValue = clamp(numberValue); | ||
| if (clampedValue === field.value) return; | ||
| field.onChange(clampedValue); | ||
| attributes?.TextInput?.onValueChange?.(clampedValue.toString(), event); | ||
| attributes?.Slider?.onValueChange?.(clampedValue); | ||
| }; |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Do not invoke the Slider callback from a text-input blur.
Line 94 invokes attributes.Slider.onValueChange after a TextInput blur. Valid text input changes use attributes.TextInput.onValueChange instead. A separate slider handler can receive an unexpected update.
Proposed fix
if (clampedValue === field.value) return;
field.onChange(clampedValue);
- attributes?.Slider?.onValueChange?.(clampedValue);
};📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| const handleTextInputBlur = (event: React.FocusEvent<HTMLInputElement>) => { | |
| const rawValue = draftValue; | |
| setDraftValue(null); | |
| attributes?.TextInput?.onBlur?.(event); | |
| if (rawValue === null || rawValue === '') return; | |
| const numberValue = parseFloat(rawValue); | |
| if (Number.isNaN(numberValue)) return; | |
| const clampedValue = clamp(numberValue); | |
| if (clampedValue === field.value) return; | |
| field.onChange(clampedValue); | |
| attributes?.TextInput?.onValueChange?.(clampedValue.toString(), event); | |
| attributes?.Slider?.onValueChange?.(clampedValue); | |
| }; | |
| const handleTextInputBlur = (event: React.FocusEvent<HTMLInputElement>) => { | |
| const rawValue = draftValue; | |
| setDraftValue(null); | |
| attributes?.TextInput?.onBlur?.(event); | |
| if (rawValue === null || rawValue === '') return; | |
| const numberValue = parseFloat(rawValue); | |
| if (Number.isNaN(numberValue)) return; | |
| const clampedValue = clamp(numberValue); | |
| if (clampedValue === field.value) return; | |
| field.onChange(clampedValue); | |
| }; |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web/packages/common/src/components/SliderWithTextInput/index.tsx` around
lines 84 - 95, The handleTextInputBlur function must not invoke
attributes?.Slider?.onValueChange?. Remove that callback invocation while
preserving the existing parsing, clamping, equality check, and field.onChange
behavior; text-input updates should continue through the TextInput callback
path.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sean Teramae steramae@nvidia.com
Summary by CodeRabbit