Skip to content

Fix fused MLA down projection with tensor parallelism#5383

Merged
sraman-rgb merged 6 commits into
NVIDIA:mainfrom
sraman-rgb:fused-mla-tp2-down-proj
Jun 26, 2026
Merged

Fix fused MLA down projection with tensor parallelism#5383
sraman-rgb merged 6 commits into
NVIDIA:mainfrom
sraman-rgb:fused-mla-tp2-down-proj

Conversation

@sraman-rgb

Copy link
Copy Markdown
Contributor
  • I, the PR author, have personally reviewed every line of this PR.

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact @NVIDIA/mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

@sraman-rgb sraman-rgb requested review from a team as code owners June 16, 2026 23:11
@copy-pr-bot

copy-pr-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci marked this pull request as draft June 16, 2026 23:11
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@sraman-rgb sraman-rgb marked this pull request as ready for review June 16, 2026 23:13
@sraman-rgb sraman-rgb enabled auto-merge June 16, 2026 23:13
@sraman-rgb

Copy link
Copy Markdown
Contributor Author

/ok to test 7ccdccd

@sraman-rgb

Copy link
Copy Markdown
Contributor Author

/ok to test 04a9966

Comment thread megatron/core/transformer/multi_latent_attention.py Outdated
Signed-off-by: Siddhartha Raman <sraman@nvidia.com>
@sraman-rgb sraman-rgb force-pushed the fused-mla-tp2-down-proj branch from 89f2ca2 to 6d253a5 Compare June 17, 2026 15:11
@sraman-rgb

Copy link
Copy Markdown
Contributor Author

/ok to test 6d253a5

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Jun 18, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Jun 25, 2026
@sraman-rgb

Copy link
Copy Markdown
Contributor Author

/ok to test c452d15

@svcnvidia-nemo-ci

Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/28207075604

Merged via the queue into NVIDIA:main with commit e1b8454 Jun 26, 2026
87 checks passed
@sraman-rgb sraman-rgb deleted the fused-mla-tp2-down-proj branch June 26, 2026 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants