-
Notifications
You must be signed in to change notification settings - Fork 212
Remove runtime.py and directly use torch dist utils + remove unused functions #667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Keval Morabia <[email protected]>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
c78d64b to
2bbd4b7
Compare
Signed-off-by: Keval Morabia <[email protected]>
2bbd4b7 to
2b5527b
Compare
e324eb7 to
092ceb1
Compare
Signed-off-by: Keval Morabia <[email protected]>
092ceb1 to
563e696
Compare
|
|
||
|
|
||
| @torch.no_grad() | ||
| def validate_pipeline( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is used by local distillation: v1/puzzle_tools/bypassed_training/stitched_pipelined.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add it when we move local distillation. By that time, we might have also removed sewing kit and instead use Nemo Automdel PP if that works
modelopt/torch/_compress/tools/validate_puzzle_with_multi_replacements.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Keval Morabia <[email protected]>
Signed-off-by: Keval Morabia <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/compress #667 +/- ##
====================================================
+ Coverage 74.37% 74.47% +0.10%
====================================================
Files 182 183 +1
Lines 18219 18416 +197
====================================================
+ Hits 13550 13715 +165
- Misses 4669 4701 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Keval Morabia <[email protected]>
examples/compress/configs/llama-3_1-8B_pruneffn_memory/validate_model_defaults.yaml
Outdated
Show resolved
Hide resolved
tests/gpu/torch/_compress/resources/configs/validate_model_defaults.yaml
Show resolved
Hide resolved
Signed-off-by: Keval Morabia <[email protected]>
What does this PR do?
runtime.pyand directly usemodelopt.torch.utils.distributedfunctionsTesting