Skip to content

Conversation

@kevalmorabia97
Copy link
Collaborator

@kevalmorabia97 kevalmorabia97 commented Dec 8, 2025

What does this PR do?

  • Remove runtime.py and directly use modelopt.torch.utils.distributed functions
  • Read model_dtype and autocast_dtype from validate_model_defaults.yaml instead of runtime object
  • Remove more unused functions
  • Remove unnecessary parse_args for intermediate steps, and improve docstrings

Testing

  • No change in functionality
  • Existing tests passing

Signed-off-by: Keval Morabia <[email protected]>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 8, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@kevalmorabia97 kevalmorabia97 force-pushed the kmorabia/compress-cleanup-2 branch from c78d64b to 2bbd4b7 Compare December 8, 2025 20:08
@kevalmorabia97 kevalmorabia97 marked this pull request as ready for review December 8, 2025 20:08
@kevalmorabia97 kevalmorabia97 requested review from a team as code owners December 8, 2025 20:08
@kevalmorabia97 kevalmorabia97 force-pushed the kmorabia/compress-cleanup-2 branch from 2bbd4b7 to 2b5527b Compare December 8, 2025 20:20
@kevalmorabia97 kevalmorabia97 requested a review from a team as a code owner December 9, 2025 15:24
@kevalmorabia97 kevalmorabia97 changed the title Remove runtime.py and directly use torch dist utils Remove runtime.py and directly use torch dist utils + remove unused functions Dec 9, 2025
@kevalmorabia97 kevalmorabia97 force-pushed the kmorabia/compress-cleanup-2 branch from e324eb7 to 092ceb1 Compare December 9, 2025 15:38
Signed-off-by: Keval Morabia <[email protected]>
@kevalmorabia97 kevalmorabia97 force-pushed the kmorabia/compress-cleanup-2 branch from 092ceb1 to 563e696 Compare December 9, 2025 19:50


@torch.no_grad()
def validate_pipeline(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is used by local distillation: v1/puzzle_tools/bypassed_training/stitched_pipelined.py

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add it when we move local distillation. By that time, we might have also removed sewing kit and instead use Nemo Automdel PP if that works

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 37.50000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.47%. Comparing base (74aae83) to head (2f8ef2e).
⚠️ Report is 62 commits behind head on feature/compress.

Files with missing lines Patch % Lines
modelopt/torch/utils/distributed.py 37.50% 10 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           feature/compress     #667      +/-   ##
====================================================
+ Coverage             74.37%   74.47%   +0.10%     
====================================================
  Files                   182      183       +1     
  Lines                 18219    18416     +197     
====================================================
+ Hits                  13550    13715     +165     
- Misses                 4669     4701      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97 kevalmorabia97 merged commit 1d8bd20 into feature/compress Dec 11, 2025
22 checks passed
@kevalmorabia97 kevalmorabia97 deleted the kmorabia/compress-cleanup-2 branch December 11, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants