[None][fix] Fix ready signal in NIXL backend

[chuangz0]

Summary by CodeRabbit

• Bug Fixes

  • Fixed readiness signal handling in cache transmission to accurately reflect actual state instead of always returning true.

• Tests

  • Added test cases for KV cache transceiver request cancellation operations with multiple attention mechanisms.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[chuangz0]

/bot run

[coderabbitai]

📝 Walkthrough

Walkthrough

A behavior modification was made to AgentConnection::recvReadySignal to return the actual readiness state instead of always returning true, and two new test cases were added to the test suite for KV cache transceiver cancel request scenarios.

Changes

Cohort / File(s)	Summary
Core Logic cpp/tensorrt_llm/executor/cache_transmission/agent_utils/connection.cpp	Modified AgentConnection::recvReadySignal to return actual readiness state (readySignalInfo.mIsReady) instead of always returning true. Behavior change propagates readiness result to callers.
Test Configuration tests/integration/test_lists/test-db/l0_sanity_check.yml	Added two new test cases: unittest/others/test_kv_cache_transceiver.py::test_cancel_request_in_transmission[mha] and test_cancel_request_in_transmission[mla].

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Specific areas requiring attention:
  • connection.cpp: Verify that all callers of recvReadySignal properly handle the now-variable return value and that the change does not break existing control flow assumptions in cache transmission logic.
  • l0_sanity_check.yml: Confirm that the referenced test cases exist and are properly parametrized with [mha] and [mla] variants.

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is incomplete and only contains the template with placeholders. Required sections like Description, Test Coverage, and specific implementation details are not filled out.	Fill in the Description section explaining the issue and solution, complete the Test Coverage section listing relevant tests, and verify the PR Checklist items have been reviewed.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies a fix to the ready signal in the NIXL backend, which aligns with the actual code change that corrects AgentConnection::recvReadySignal to return the actual readiness state instead of always true.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 504ede7 and 5ad5f65.

📒 Files selected for processing (2)

• cpp/tensorrt_llm/executor/cache_transmission/agent_utils/connection.cpp (1 hunks)
• tests/integration/test_lists/test-db/l0_sanity_check.yml (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{cpp,h,cu}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.{cpp,h,cu}: Closing braces of namespaces should have a comment saying the namespace it closes (e.g., } // namespace foo)
Prefer const or constexpr variables over #define whenever possible, as the latter are not visible to the compiler
A variable that is not modified after its initialization should be declared as const
Except 0 (only used in comparison for checking signness/existence/emptiness) and nullptr, true, false, all other literals should only be used for variable initialization and should be replaced with named constants
Use Allman indentation style for braces in C++
Put the semicolon for an empty for or while loop in a new line
The statement forming the body of a switch, while, do .. while or for statement shall be a compound statement (use brace-delimited statements)
If and else should always be followed by brace-delimited statements, even if empty or a single statement
C++ filenames should use camel case with first letter lowercase (e.g., thisIsASubDir and thisIsAFilename.cpp)
All filenames involved in compilation of a compilation target must have case-insensitive unique filenames
All types (including class names) should use camel case with uppercase first letter (e.g., FooBarClass)
Local variables, methods and namespaces should use camel case with first letter lowercase (e.g., localFooBar)
Non-magic-number global variables that are non-static and not defined in anonymous namespace should use camel case prefixed by a lower case 'g' (e.g., gDontUseGlobalFoos)
Non-magic-number global variables that are static or defined in an anonymous namespace should use camel case prefixed by a lower case 's' (e.g., sMutableStaticGlobal)
Locally visible static variables should use camel case with lowercase prefix 's' as the first letter of the name (e.g., static std::once_flag sFlag;)
Public, private and protected class member variables should use camel case prefixed with 'm' (e.g., mNbFooValues), though the 'm' pre...

Files:

• cpp/tensorrt_llm/executor/cache_transmission/agent_utils/connection.cpp

**/*.{cpp,h,cu,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

All TensorRT-LLM Open Source Software code files should contain an NVIDIA copyright header that includes the current year at the top

Files:

• cpp/tensorrt_llm/executor/cache_transmission/agent_utils/connection.cpp

🧠 Learnings (4)

📚 Learning: 2025-09-09T09:40:45.658Z

Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

• tests/integration/test_lists/test-db/l0_sanity_check.yml

📚 Learning: 2025-07-28T17:06:08.621Z

Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

• tests/integration/test_lists/test-db/l0_sanity_check.yml

📚 Learning: 2025-08-26T09:49:04.956Z

Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

• tests/integration/test_lists/test-db/l0_sanity_check.yml

📚 Learning: 2025-08-29T14:07:45.863Z

Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

• tests/integration/test_lists/test-db/l0_sanity_check.yml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

🔇 Additional comments (1)

tests/integration/test_lists/test-db/l0_sanity_check.yml (1)

37-38: Good test coverage for cancellation scenarios.

The new test cases appropriately cover request cancellation during transmission for both mha and mla variants. These tests complement the existing KV cache transceiver tests (lines 35-36) and provide coverage for the ready signal fix in the connection code.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tensorrt-cicd]

PR_Github #28342 [ run ] triggered by Bot. Commit: 5ad5f65

[tensorrt-cicd]

PR_Github #28342 [ run ] completed with state SUCCESS. Commit: 5ad5f65
/LLM/main/L0_MergeRequest_PR pipeline #21682 completed with status: 'FAILURE'

[pcastonguay]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #28434 [ run ] triggered by Bot. Commit: 5ad5f65

[tensorrt-cicd]

PR_Github #28434 [ run ] completed with state SUCCESS. Commit: 5ad5f65
/LLM/main/L0_MergeRequest_PR pipeline #21762 completed with status: 'FAILURE'

[chuangz0]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #28475 [ run ] triggered by Bot. Commit: 7b0c0a4

[tensorrt-cicd]

PR_Github #28475 [ run ] completed with state SUCCESS. Commit: 7b0c0a4
/LLM/main/L0_MergeRequest_PR pipeline #21803 completed with status: 'FAILURE'

[chuangz0]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #28552 [ run ] triggered by Bot. Commit: 55b1939

[tensorrt-cicd]

PR_Github #28552 [ run ] completed with state SUCCESS. Commit: 55b1939
/LLM/main/L0_MergeRequest_PR pipeline #21870 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[pcastonguay]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #28613 [ run ] triggered by Bot. Commit: 55b1939

[tensorrt-cicd]

PR_Github #28613 [ run ] completed with state DISABLED
CI server is currently disabled for scheduled maintenance. Estimated completion time: 1 PM PST on 12/16.

[pcastonguay]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #28620 [ run ] triggered by Bot. Commit: 55b1939

[tensorrt-cicd]

PR_Github #28620 [ run ] completed with state DISABLED
CI server is currently disabled for scheduled maintenance. Estimated completion time: 1 PM PST on 12/16.

[chuangz0]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #28646 [ run ] triggered by Bot. Commit: 9a7cdea

[tensorrt-cicd]

PR_Github #28646 [ run ] completed with state DISABLED
CI server is currently disabled for scheduled maintenance. Estimated completion time: 1 PM PST on 12/16.

[pcastonguay]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #28773 [ run ] triggered by Bot. Commit: 9a7cdea

[tensorrt-cicd]

PR_Github #28773 [ run ] completed with state SUCCESS. Commit: 9a7cdea
/LLM/main/L0_MergeRequest_PR pipeline #22020 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[pcastonguay]

/bot run --disable-fail-fast

[tburt-nv]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #28821 [ run ] triggered by Bot. Commit: 9a7cdea

[tensorrt-cicd]

PR_Github #28821 [ run ] completed with state FAILURE. Commit: 9a7cdea
/LLM/main/L0_MergeRequest_PR pipeline #22065 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[chuangz0]

/bot run --disable-fail-fast

[chuangz0]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #28934 [ run ] triggered by Bot. Commit: d9566b5

[tensorrt-cicd]

PR_Github #28934 [ run ] completed with state SUCCESS. Commit: d9566b5
/LLM/main/L0_MergeRequest_PR pipeline #22162 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[pcastonguay]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #28993 [ run ] triggered by Bot. Commit: d9566b5

[tensorrt-cicd]

PR_Github #28993 [ run ] completed with state SUCCESS. Commit: d9566b5
/LLM/main/L0_MergeRequest_PR pipeline #22217 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

[pcastonguay]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #29030 [ run ] triggered by Bot. Commit: d9566b5

[tensorrt-cicd]

PR_Github #29030 [ run ] completed with state SUCCESS. Commit: d9566b5
/LLM/main/L0_MergeRequest_PR pipeline #22251 completed with status: 'SUCCESS'