-
Notifications
You must be signed in to change notification settings - Fork 329
Ft testing test fixes #2454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ft testing test fixes #2454
Changes from all commits
bdffa0b
8caf6e6
2b6fe34
2232f01
ba564dd
8c335e8
6757a01
a9a2116
ea7cb70
2f90d7a
e90369f
9f142e9
d4192a4
443921a
a98fc52
d920526
0bde899
ca4c746
bdc5f0f
bc026aa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -685,6 +685,7 @@ def test_event_survives_graph_clone_and_execution(init_cuda): | |
| # ============================================================================= | ||
|
|
||
|
|
||
| @pytest.mark.thread_unsafe(reason="asserts cleanup on main thread") | ||
| @pytest.mark.agent_authored(model="gpt-5.6") | ||
| def test_user_object_cleanup_is_coalesced_on_python_thread(init_cuda): | ||
| """More than 32 CUDA callbacks drain through one main-thread pending call.""" | ||
|
|
@@ -1412,6 +1413,7 @@ def test_memcpy_buffer_survives_close(init_cuda): | |
| assert list(out) == [0xCD] * 4 | ||
|
|
||
|
|
||
| @pytest.mark.thread_unsafe(reason="deferred cleanup on main thread which would wait") | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are three tests here that fail with I suspect that is a potential but very minor issue (you would think eventually this cleanup happens). But wanted to make a comment. I didn't try to understand what is going on here exactly!
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The issue is that deferred cleanup requires Python's main thread.
The test also needs to be updated to use |
||
| @pytest.mark.agent_authored(model="claude-opus-4.8") | ||
| def test_memcpy_buffer_allocations_released_after_graph_destroyed(init_cuda): | ||
| """Destroying the graph frees both memcpy operand allocations. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dunno if others get a pop-up for these tests, I did and with parallel testing, it might be a 100 windows :).