-
Notifications
You must be signed in to change notification settings - Fork 328
fix(pathfinder): use exact dynamic library names #2689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rwgk
wants to merge
6
commits into
NVIDIA:main
Choose a base branch
from
rwgk:pathfinder_wildcard_cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7c3426f
Use exact Windows DLL names for CUPTI
rwgk f20ad66
Use exact Linux SONAMEs for library discovery
rwgk 6eb600b
Declare the Linux NVVM wheel filename
rwgk aae8753
docs(pathfinder): prepare 1.7.1 release notes
rwgk acefd25
Merge branch 'main' into pathfinder_wildcard_cleanup
rwgk f370ee1
docs(pathfinder): clarify 1.7.1 wildcard changes
rwgk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| .. SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| .. SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| .. py:currentmodule:: cuda.pathfinder | ||
|
|
||
| ``cuda-pathfinder`` 1.7.1 Release notes | ||
| ======================================= | ||
|
|
||
| Bugfixes | ||
| -------- | ||
|
|
||
| * Restrict Windows CUPTI filesystem discovery to descriptor-declared DLL | ||
| names. Removing its wildcard fallback keeps candidate selection consistent | ||
| with already-loaded detection and native loading, and prevents undeclared | ||
| DLL names from being selected. | ||
| (`PR #2689 <https://github.com/NVIDIA/cuda-python/pull/2689>`_) | ||
|
|
||
| * Make Linux filesystem discovery, already-loaded detection, and native loading | ||
| use one descriptor-declared, newest-first library filename list. Remove the | ||
| implicit ``lib<name>.so`` and broad ``.so*`` filesystem fallbacks, so | ||
| explicit directory layouts must expose a declared filename. Explicitly | ||
| declare the unversioned ``libnvvm.so`` wheel filename to preserve CUDA 12.9 | ||
| wheel discovery, and correct the ``cufftMp`` catalog order so ABI 12 is | ||
| preferred over ABI 11. | ||
| (`PR #2689 <https://github.com/NVIDIA/cuda-python/pull/2689>`_) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have to keep two orders? If all we need is newest -> oldest, should we enforce it when we author it, then just use as-is? Also, I'm not sure if the "oldest -> newest" description is 100% accurate, for instance, nvvm soname:
There isn't a chronological order between these two names.