feat(cuda.core): support CU_LAUNCH_ATTRIBUTE_PRIORITY in LaunchConfig - #2706
Open
ichensun wants to merge 1 commit into
Open
feat(cuda.core): support CU_LAUNCH_ATTRIBUTE_PRIORITY in LaunchConfig#2706ichensun wants to merge 1 commit into
ichensun wants to merge 1 commit into
Conversation
Contributor
github-actions
Bot
added
the
cuda.core
Contributor
|
/ok to test b963404 |
|
lijinf2
reviewed
Aug 28, 2026
| Whether to allow programmatic stream serialization (PDL). When True, | ||
| the kernel may overlap with a previous kernel in the same stream that | ||
| signals completion via programmatic means. | ||
| priority : int, optional |
Contributor
There was a problem hiding this comment.
Do we have a range for the value we can set? It cannot be any number.
CUDA doc should provide guidance on what value to set. Let's include the guidance in docstring.
lijinf2
reviewed
Aug 28, 2026
| shmem_size: int | ||
| is_cooperative: bool | ||
| programmatic_stream_serialization: bool | ||
| priority: object |
Contributor
There was a problem hiding this comment.
Let's define type as "int" here to be consistent with line 42.
lijinf2
reviewed
Aug 28, 2026
| attr.value.programmaticStreamSerializationAllowed = 1 | ||
| self._attrs.push_back(attr) | ||
|
|
||
| if self.priority is not None: |
Contributor
There was a problem hiding this comment.
Let's follow cuda.core.Stream(priority) value checking and default behavior here to stay consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
issues #2631
Adds a
priorityattribute toLaunchConfigthat maps toCU_LAUNCH_ATTRIBUTE_PRIORITY,following the same pattern used for
programmatic_stream_serialization(#1334).priority: int | None = None(defaultNone) — when omitted, the launchuses the stream's priority, matching existing
LaunchConfigattributeconventions.
0and negative values are valid,meaningful priorities, not sentinels for "unset". Because of this, the
attribute is stored as a nullable
object(not a Cint) internally, andboth native-config conversion paths (
LaunchConfig._to_native_launch_configand the module-level
_to_native_launch_config) checkis not Noneratherthan truthiness, so
priority=0is set correctly instead of being dropped.is_cooperative), since the driver accepts any priority within thedevice's stream-priority range and clamps/errors on its own.