cuda.core: fix a few test issues - #2714
Open
juenglin wants to merge 7 commits into
Open
Conversation
Contributor
github-actions
Bot
added
cuda.bindings
juenglin
commented
Aug 27, 2026
| assert buf.handle == 0 | ||
|
|
||
|
|
||
| @pytest.mark.xfail( |
juenglin
added
P1
juenglin
force-pushed
the
graphics-tests-followup
branch
from
August 27, 2026 21:53
1c5bd29 to
2b149cf
Compare
juenglin
force-pushed
the
graphics-tests-followup
branch
from
August 27, 2026 22:02
2b149cf to
92eb2ee
Compare
Contributor
Author
|
/ok to test 6854ccb |
juenglin
marked this pull request as ready for review
August 27, 2026 22:17
juenglin
force-pushed
the
graphics-tests-followup
branch
from
August 27, 2026 23:00
6854ccb to
9a28ab6
Compare
Contributor
Author
|
/ok to test 9a28ab6 |
|
juenglin
force-pushed
the
graphics-tests-followup
branch
from
August 27, 2026 23:31
9a28ab6 to
f05c176
Compare
Contributor
Author
|
/ok to test f05c176 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #2701 addressing review feedback and the test-guidance cleanup noted in
cleanup-importorskip-dead-code.md.test_close_while_mapped_passes_stream_override(xfail from cuda.core: Fix graphics tests #2701); the stream-forwarding behavior ofBuffer.close()is covered elsewhere, and the test asserted on internal call dispatch viapatch.objecton an immutable Cython type._setup_gl_buffer/_setup_gl_textureincuda_coreandcuda_bindings): a failure after the window opens now closes the window before re-raising.pytest.importorskipcalls for declared dependencies:Cython/setuptoolsintest_build_hooks.pyandcuda.pathfinderintest_device_launch.py, replaced with top-level imports so a missing install fails collection.except Exceptionto pyglet's "GL unavailable" exceptions (matched by name to avoid pyglet's import-time shadow-window side effect), so a bug in our own setup code re-raises instead of being hidden as a skip._compile_heat_kernels/_compile_bisect_kernelsintest_graph_definition_integration.pyfrom bareexcept Exceptionto a narrow match on NVRTC'scudaGraphConditionalHandle is undefineddiagnostic, so a real compile error fails instead of skipping.Checklist