Fix NVML CUDA device-order test early return - #2768
Merged
Merged
Conversation
Remove the return accidentally retained when the Tegra skip check was converted to a loop. Supported systems now reach the CUDA/NVML device comparison, and the loop can check both Orin and Thor.
rwgk
added
bug
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
rwgk
marked this pull request as ready for review
September 4, 2026 19:35
rwgk
enabled auto-merge (squash)
September 4, 2026 19:42
This comment has been minimized.
This comment has been minimized.
mdboom
approved these changes
Sep 4, 2026
sylvesterkaczmarek
left a comment
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
This is a real test-control-flow bug: the unconditional return exits after the first Orin check even on ordinary systems, so neither Thor detection nor the CUDA/NVML ordering assertion runs. Removing it restores the intended skip-only semantics for special device naming without changing production code. Tiny patch, but the effect is meaningful because the main assertion was effectively disabled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #2742.
Remove an accidentally retained
returnfromtest_cuda_device_order(). It currently exits after the first device-kind check on every supported system, so it never checks Thor and never compares the CUDA and NVML device lists.Checklist