fix(setup.sh): guard SIGPIPE in site-agent pod lookup (spurious [7h] Code 141)#2676
Open
kirson-git wants to merge 1 commit into
Open
fix(setup.sh): guard SIGPIPE in site-agent pod lookup (spurious [7h] Code 141)#2676kirson-git wants to merge 1 commit into
kirson-git wants to merge 1 commit into
Conversation
…lure) `_POD="$(kubectl get pods ... -o name 2>/dev/null | head -1)"` runs under `set -euo pipefail`. `head -1` closes the pipe early, kubectl gets SIGPIPE and exits 141; pipefail propagates it, so the [7h] site-agent phase aborts with 'SETUP FAILED ... Code: 141' even though site-agent deployed successfully (StatefulSet ready, Site CR HandshakeComplete). Add '|| true' so the pipe result is tolerated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: kirson-git <ekirson@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughIn ChangesNICo REST Site-Agent gRPC Verification Loop
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the
[7h]site-agent verification, the pod lookup is:The script runs under
set -euo pipefail(line 77).head -1closes the pipe after the first line, kubectl receives SIGPIPE → exit 141, andpipefailpropagates it, so the command substitution fails and the phase aborts withSETUP FAILED ... Code: 141— even though site-agent deployed fine (StatefulSet ready, Site CRHandshakeComplete). Reproduced on a clean v0.10.3 install; same code onmain.Fix
Append
|| trueso the SIGPIPE-induced 141 is tolerated.🤖 Generated with Claude Code