Fix missing num_steps parameter for stochastic sampler#1364
Fix missing num_steps parameter for stochastic sampler#1364younes-abid wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
- Add missing num_steps=cfg.sampler.num_steps parameter to stochastic_sampler partial() call - This bug caused stochastic sampler to always use default 18 steps instead of configured num_steps - Fixes inconsistency with deterministic sampler which correctly passes num_steps parameter - Improves performance when using fewer diffusion steps (e.g., num_steps=2)
Greptile OverviewGreptile SummaryFixes a bug in the CorrDiff generation pipeline where the stochastic sampler was ignoring the configured Changes:
Impact: Important Files Changed
|
CharlelieLrt
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
|
/blossom-ci |
|
/blossom-ci |
|
@younes-abid the CI tests are failing because of code-formatting issues. Did you have pre-commit installed as detailed in the contributing guidelines? If not, you need to ruff-format your files |
|
@younes-abid following up on this. Could you please format your modified file such that we can then merge your PR? Thanks! |
|
ok |
PhysicsNeMo Pull Request
Description
This PR fixes a bug in the CorrDiff generation pipeline where the stochastic sampler was ignoring the configured num_steps
parameter and always using the default value of 18 steps, causing performance issues.
Problem: In generate.py, the partial() call for stochastic_sampler was missing the num_steps parameter, while the deterministic sampler correctly included it.
Solution: Added the missing num_steps=cfg.sampler.num_steps parameter to the stochastic sampler configuration.
Checklist
Dependencies
No new dependencies required.
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.