Skip to content

Clean up multi-piped sed command in Makefile#3187

Merged
stevengj merged 1 commit intoNanoComp:masterfrom
oskooi:makefile_sed_cleanup
Apr 3, 2026
Merged

Clean up multi-piped sed command in Makefile#3187
stevengj merged 1 commit intoNanoComp:masterfrom
oskooi:makefile_sed_cleanup

Conversation

@oskooi
Copy link
Copy Markdown
Collaborator

@oskooi oskooi commented Apr 2, 2026

The multi-piped sed on line 37 of src/Makefile.am is replaced with a single sed invocation using multiple -e flags. The new form is easier to read, extend (just add another -e line), and run as a single process instead of five.

The regenerated step_generic_stride1.cpp is byte-identical to the original, confirming correctness.

@oskooi oskooi changed the title Cleanup multi-piped sed command in Makefile Clean up multi-piped sed command in Makefile Apr 2, 2026
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.87%. Comparing base (f29a8c7) to head (cb81016).
⚠️ Report is 120 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3187      +/-   ##
==========================================
+ Coverage   73.81%   73.87%   +0.05%     
==========================================
  Files          18       18              
  Lines        5423     5458      +35     
==========================================
+ Hits         4003     4032      +29     
- Misses       1420     1426       +6     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevengj stevengj merged commit c986509 into NanoComp:master Apr 3, 2026
5 checks passed
@oskooi oskooi deleted the makefile_sed_cleanup branch April 3, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants