Clean up multi-piped sed command in Makefile#3187
Merged
stevengj merged 1 commit intoNanoComp:masterfrom Apr 3, 2026
Merged
Conversation
sed command in Makefilesed command in Makefile
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3187 +/- ##
==========================================
+ Coverage 73.81% 73.87% +0.05%
==========================================
Files 18 18
Lines 5423 5458 +35
==========================================
+ Hits 4003 4032 +29
- Misses 1420 1426 +6 🚀 New features to boost your workflow:
|
stevengj
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multi-piped
sedon line 37 ofsrc/Makefile.amis replaced with a singlesedinvocation using multiple-eflags. The new form is easier to read, extend (just add another-eline), and run as a single process instead of five.The regenerated
step_generic_stride1.cppis byte-identical to the original, confirming correctness.