Fix bug in fields::_require_component when allocating new fields#3188
Open
oskooi wants to merge 5 commits intoNanoComp:masterfrom
Open
Fix bug in fields::_require_component when allocating new fields#3188oskooi wants to merge 5 commits intoNanoComp:masterfrom
fields::_require_component when allocating new fields#3188oskooi wants to merge 5 commits intoNanoComp:masterfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3188 +/- ##
==========================================
+ Coverage 73.81% 73.87% +0.05%
==========================================
Files 18 18
Lines 5423 5458 +35
==========================================
+ Hits 4003 4032 +29
- Misses 1420 1426 +6 🚀 New features to boost your workflow:
|
Collaborator
|
This could be triggered if you do some timestepping, and then add a source (triggering field allocation). I think we don't see this bug currently because we virtually always create fields at the beginning and then timestep. |
stevengj
reviewed
Apr 3, 2026
…ponent and hence trigger sync_chunk_connections lazily
…led" This reverts commit 1455562.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
fields::_require_component()insrc/fields.cpp:553allocates new field arrays when a source is added (viaalloc_f), and setschunk_connections_valid = false, but does not setchanged_materials = true. On the nextstep()call,step_db()lazily allocates PML auxiliary arrays (f_u) for the newly-created field components, which requireschanged_materialsto betrueper the assertion.Fix: (
src/fields.cpp:568-573): Setchanged_materials = truewhen_require_componentallocates new fields.