Conversation
|
OK, I think we're building with CXX20 now. 17e6c17 can probably be ignored. This is just fully qualifying most of the Assuming there is agreement to move forward here, I would propose this gets merged soon. We can then slowly begin to migrate |
|
Other things to note: fmt-8.0.1 and Eigen were patched. The first doesn't matter really since I think want to get rid of it anyway, and Eigen will probably be updated when kiva eventually gets upgraded. |
|
@mitchute It looks like most of the changes in "E+ proper" are to formatting operations. Is that correct? I guess the only question I have is if this would complicate anything on less-standard platforms. |
|
That’s correct. By “less standard” are you referring to Red Hat or some other HPC environment? |
|
@mitchute Yes, but also I recall that there was some cut-down environment that was getting used to build the code for Python packaging purposes. Not sure what all happened with that. |
|
@jasondegraw it looks like manylinux_2_28 uses GCC 14, which has full C++ 20 support. manylinux_2_28 is in ELTS, and given that there are a number of newer versions available, I'm not expecting any issues related to this. |
|
After testing, we'll merge this next while the PR list is relatively small. |
|
Alrighty. I've been dragging my feet, but everything is clean and the PR list is relatively small, so I don't expect many conflicts. Even so, the bulk of the changes in this branch are very simple, so it should be pretty straightforward to resolve them. Ping me if that situation come up and I can take care of it. Merging. |
Pull request overview
Upgrades to use C++20 standard. Summary of changes:
formatare now qualified by eitherfmtorEnergyPlusso as to not conflict withstd::formatwhich is now available. All of these will slowly be transitioned over to usestd::format.Description of the purpose of this PR
Pull Request Author
Reviewer