fix(mdbx): report initialization failures#115
Merged
Conversation
Notify the configured error callback for constructor-time storage failures so logger registration can surface the cause before the exception prevents a broken backend from being added. Constraint: Keep MdbxLogger C++17-compatible and preserve constructor rethrow semantics Confidence: high Scope-risk: narrow Not-tested: Full test suite; only mdbx_logger_test was run Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Use filesystem path decomposition in the init failure regression test so the blocker path follows the same path semantics as the nested MDBX path under test. Constraint: Keep the change limited to test robustness Confidence: high Scope-risk: narrow Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Keep the MDBX regression test self-contained for pre-C++17 parses even though the MDBX backend is configured as C++17-only. Constraint: Preserve current CMake LOGIT_WITH_MDBX C++17 requirement Confidence: high Scope-risk: narrow Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Pull the latest mdbx-containers fixes into the MDBX logger initialization PR so path handling uses the updated dependency behavior. Constraint: Keep unrelated local guide edits out of this PR update Confidence: high Scope-risk: narrow Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
🤖 Generated with Claude Code