Skip to content

python3Packages.twilio: fix tests on Python 3.14#524031

Merged
fabaff merged 1 commit into
NixOS:masterfrom
LisaScheers:twilio-python314-checks
May 30, 2026
Merged

python3Packages.twilio: fix tests on Python 3.14#524031
fabaff merged 1 commit into
NixOS:masterfrom
LisaScheers:twilio-python314-checks

Conversation

@LisaScheers

@LisaScheers LisaScheers commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Applies an upstream Twilio patch that replaces aiounittest.AsyncTestCase with the stdlib unittest.IsolatedAsyncioTestCase, fixing the check suite on Python 3.14.

This removes the aiounittest check dependency from the package and keeps the test suite enabled on Python 3.14.

Verified with nix-build -A python314Packages.twilio --no-out-link.

Automation disclosure: this code change, commit message, and PR text were prepared with OpenAI Codex (GPT-5).

Things done

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 12.first-time contribution This PR is the author's first one; please be gentle! 6.topic: python Python is a high-level, general-purpose programming language. labels May 25, 2026
applePrincess
applePrincess reviewed May 25, 2026
View reviewed changes
Comment thread pkgs/development/python-modules/twilio/default.nix
@LisaScheers LisaScheers force-pushed the twilio-python314-checks branch from 2416593 to 189ed45 Compare May 25, 2026 15:07
@LisaScheers LisaScheers changed the title python3Packages.twilio: skip checks on Python 3.14 python3Packages.twilio: skip aiounittest tests on Python 3.14 May 25, 2026
@LisaScheers LisaScheers force-pushed the twilio-python314-checks branch from 189ed45 to e6e56ad Compare May 25, 2026 15:08
@nixpkgs-ci nixpkgs-ci Bot removed the 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. label May 25, 2026
@LisaScheers LisaScheers force-pushed the twilio-python314-checks branch from e6e56ad to 2b85691 Compare May 25, 2026 15:15
@applePrincess

applePrincess commented May 25, 2026

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 524031
Commit: e6e56ad7a7b16d12ede175f890536e6c35911d44 (subsequent changes)
Merge: c743d6391fd7247b8d18438a7f615e3697c88792

Logs: https://github.com/applePrincess/nixpkgs-review-gha/actions/runs/26407363439

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-524031-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-review-gha-appleprincess.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs-review-gha-appleprincess.cachix.org-1:Lcqj6NTTNQxhQdLKNyOfqhEzwCk+oQI2uxssvV8zPDo=
  ' \
  /nix/store/78cm2q37cz73960k0f059yh6zwf8v93a-authentik-2025.12.5 \
  /nix/store/y76r4zxim2fydk9v89585sx2lfws7q5d-python3.13-twilio-9.10.9 \
  /nix/store/jbjkppaypgg45lrxsg1k2dg292wpvwrw-python3.13-twilio-9.10.9-dist \
  /nix/store/ycmfxx2zx67yfwj36ick458svsiiffmy-python3.14-twilio-9.10.9 \
  /nix/store/fhm907f6q5q59mnfvr78nav0nq733w05-python3.14-twilio-9.10.9-dist \
  /nix/store/7jph0mgas6l8r4vny824vk32w0f6yjs2-homeassistant-test-twilio-2026.5.4
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-524031-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-review-gha-appleprincess.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs-review-gha-appleprincess.cachix.org-1:Lcqj6NTTNQxhQdLKNyOfqhEzwCk+oQI2uxssvV8zPDo=
  ' \
  /nix/store/xsji7h0q43ww8kk0f36490rfcbbxxxki-authentik-2025.12.5 \
  /nix/store/4m4qsgs09qvdv5ywans2v1n4xwq6alsp-python3.13-twilio-9.10.9 \
  /nix/store/sqdgs4kqshsf4yazkdyjjwwaj86agzgp-python3.13-twilio-9.10.9-dist \
  /nix/store/cwfbiljc8c8scn3pmcbivliin8wz98d5-python3.14-twilio-9.10.9 \
  /nix/store/hqc9drcfwdb9mnih1vssm2q3cwyn3a5f-python3.14-twilio-9.10.9-dist \
  /nix/store/ngmgiykibxdwsrpd90g5k0icfbfkh3yh-homeassistant-test-twilio-2026.5.4
  • x86_64-darwin 
    nix-store -r --add-root nixpkgs-pr-524031-x86_64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-review-gha-appleprincess.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs-review-gha-appleprincess.cachix.org-1:Lcqj6NTTNQxhQdLKNyOfqhEzwCk+oQI2uxssvV8zPDo=
  ' \
  /nix/store/rk2m16fgdq0fbhfm4c8ynvby6khwwk66-python3.13-twilio-9.10.9 \
  /nix/store/9i327x7y9pzanw1w3h0xr98f7iswvnsl-python3.13-twilio-9.10.9-dist \
  /nix/store/nf50baqmn4g2axm8y83m1aqv3zwf5zhd-python3.14-twilio-9.10.9 \
  /nix/store/y0i8fq5m0b29frk8nksz11wjr8438zzb-python3.14-twilio-9.10.9-dist
  • aarch64-darwin 
    nix-store -r --add-root nixpkgs-pr-524031-aarch64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-review-gha-appleprincess.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs-review-gha-appleprincess.cachix.org-1:Lcqj6NTTNQxhQdLKNyOfqhEzwCk+oQI2uxssvV8zPDo=
  ' \
  /nix/store/31i9cq28v14y47sdkyn35q02yia7lzys-python3.13-twilio-9.10.9 \
  /nix/store/0kmk1fh900hwqzn8wvq8imxpwsy107d7-python3.13-twilio-9.10.9-dist \
  /nix/store/dq4ccs0gy7pyix1zk9wmdkkdvvs8yff9-python3.14-twilio-9.10.9 \
  /nix/store/g8d52rm9lv5fprb1v05j0812h7kkg0bj-python3.14-twilio-9.10.9-dist

x86_64-linux

✅ 4 packages built:
  • authentik
  • python313Packages.twilio
  • python314Packages.twilio
  • tests.home-assistant-components.twilio

aarch64-linux

✅ 4 packages built:
  • authentik
  • python313Packages.twilio
  • python314Packages.twilio
  • tests.home-assistant-components.twilio

x86_64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • python313Packages.twilio
  • python314Packages.twilio

aarch64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • python313Packages.twilio
  • python314Packages.twilio

@LisaScheers LisaScheers marked this pull request as ready for review May 25, 2026 15:26
@nixpkgs-ci nixpkgs-ci Bot requested a review from fabaff May 25, 2026 16:10
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 25, 2026
fabaff
fabaff reviewed May 25, 2026
View reviewed changes
Comment thread pkgs/development/python-modules/twilio/default.nix
@LisaScheers LisaScheers mentioned this pull request May 26, 2026
Merged
14 tasks
@LisaScheers LisaScheers changed the title python3Packages.twilio: skip aiounittest tests on Python 3.14 python3Packages.twilio: fix tests on Python 3.14 May 26, 2026
@LisaScheers LisaScheers force-pushed the twilio-python314-checks branch from 2b85691 to fdc6e68 Compare May 26, 2026 16:36
SuperSandro2000
SuperSandro2000 reviewed May 26, 2026
View reviewed changes
Comment thread pkgs/development/python-modules/twilio/default.nix Outdated
@LisaScheers

LisaScheers commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 524031
Commit: fdc6e68c3c5f962659e03c5fce18699350563de3 (subsequent changes)
Merge: 1db53e1a6863290f799c24baa800bb653c11e58d

Logs: https://github.com/LisaScheers/nixpkgs-review-gha/actions/runs/26461767266

x86_64-linux

✅ 4 packages built:
  • authentik
  • python313Packages.twilio
  • python314Packages.twilio
  • tests.home-assistant-components.twilio

aarch64-linux

✅ 4 packages built:
  • authentik
  • python313Packages.twilio
  • python314Packages.twilio
  • tests.home-assistant-components.twilio

x86_64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • python313Packages.twilio
  • python314Packages.twilio

aarch64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • python313Packages.twilio
  • python314Packages.twilio

@LisaScheers
python3Packages.twilio: fix tests on Python 3.14
4030b9e 
Assisted-by: OpenAI Codex (GPT-5)
@LisaScheers LisaScheers force-pushed the twilio-python314-checks branch from fdc6e68 to 4030b9e Compare May 26, 2026 17:44
@fabaff

fabaff commented May 29, 2026

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 524031
Commit: 4030b9e48f85854d2531178c81bb4ac860b6d10e

x86_64-linux

✅ 4 packages built:
  • authentik
  • python313Packages.twilio
  • python314Packages.twilio
  • tests.home-assistant-components.twilio

@nixpkgs-ci nixpkgs-ci Bot removed the 12.first-time contribution This PR is the author's first one; please be gentle! label May 29, 2026
fabaff
fabaff approved these changes May 30, 2026
View reviewed changes

@fabaff fabaff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff added this pull request to the merge queue May 30, 2026
Merged via the queue into NixOS:master with commit 031fd90 May 30, 2026
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabaff fabaff fabaff approved these changes
@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000
+1 more reviewer
@applePrincess applePrincess applePrincess approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LisaScheers @applePrincess @fabaff @SuperSandro2000