refactor: employ useAsync composable to reduce repeated patterns in A…#79
Draft
uier wants to merge 1 commit into
Draft
refactor: employ useAsync composable to reduce repeated patterns in A…#79uier wants to merge 1 commit into
uier wants to merge 1 commit into
Conversation
Deploying with
|
| Latest commit: |
34bdc74
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a2be1e55.nfe.pages.dev |
| Branch Preview URL: | https://refactor-use-async.nfe.pages.dev |
Member
Author
|
@Bogay @laporchen Please take a look first before I replace all the similar patterns into new style. |
laporchen
reviewed
Mar 10, 2023
Bogay
reviewed
Mar 10, 2023
Comment on lines
+11
to
+16
| if (!error.value) return null; | ||
| else if (axios.isAxiosError(error.value) && error.value.response?.data?.message) { | ||
| return error.value.response.data.message; | ||
| } else { | ||
| return "Unknown error occurred :("; | ||
| } |
Member
There was a problem hiding this comment.
I prefer to use early return to eliminate some nested code.
Suggested change
| if (!error.value) return null; | |
| else if (axios.isAxiosError(error.value) && error.value.response?.data?.message) { | |
| return error.value.response.data.message; | |
| } else { | |
| return "Unknown error occurred :("; | |
| } | |
| if (!error.value) return null; | |
| if (axios.isAxiosError(error.value) && error.value.response?.data?.message) { | |
| return error.value.response.data.message; | |
| } | |
| return "Unknown error occurred :("; |
Member
Author
There was a problem hiding this comment.
that's a good point, will fix this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…PI calls
close #32