Add FoldGRPO advantage estimator and process_rewards pipeline #1514
Open
sumi-fleet-hub wants to merge 5 commits into
Open
Add FoldGRPO advantage estimator and process_rewards pipeline #1514sumi-fleet-hub wants to merge 5 commits into
sumi-fleet-hub wants to merge 5 commits into
Conversation
fix test unpackings for 8-tuple return
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
SumanthRH
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the FoldGRPO advantage estimator from Scaling Long-Horizon LLM Agent via Context-Folding and the process_rewards plumbing needed to support it.
What is FoldGRPO
FoldGRPO is GRPO with token-level process rewards. The group baseline is computed from outcome rewards only:
Today SkyRL's reward path only carries a single channel (GeneratorOutput, TrainingInputBatch, advantage estimator), used for outcome rewards. There's no way to pass process rewards alongside them. This PR adds that second channel.
Changes
All changes are optional and None-safe. Existing algorithms and environments are unaffected.
What this does not include
The branching/folding scaffold (branch/return tools, KV-cache rollback, context management during rollout) and the process reward computation (Unfolded-Token Penalty, Out-of-Scope Penalty, Failure Penalty) are application-specific and live outside the core framework. This PR provides the training-side plumbing so environments that emit process rewards can use them.