Allows disconnected to pass code and reason

[zedtux]

No description provided.

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[NullVoxPopuli]

Hi @zedtux ! thanks for the PR! can you add information about this to the README as well? thanks!

[zedtux]

Done sir!

[zedtux]

Any news please?

[NullVoxPopuli]

it's been a while for me, but where would someone find out what possible codes and reasons could be passed here?

[zedtux]

I have no idea! The last one I had was reason being AuthError, I don't remember the code.

I guess you can find it from the ActionCable protocol specification, but Is that important for this PR?

[NullVoxPopuli]

nah, thanks! It's just been ages since I've worked with Rails' things

[zedtux]

👍

[NullVoxPopuli]

it seems CI isn't set up on this repo 😅 would you be willing to PR a GH action workflow that sets that up?
Travis no longer does anything, but this was the config used: https://github.com/NullVoxPopuli/action_cable_client/blob/master/.travis.yml

[zedtux]

I'm not sure I can create a PR with that and get it running on your repo, is there any kind of permissions for that?

[NullVoxPopuli]

We'll find out! 🎉

[StantonMatt]

I took a quick maintenance pass here while working on the CI/lint setup requested above.

Local validation on this branch:

• bundle exec rspec -> 49 examples, 0 failures
• bundle exec ruby -Ilib -e 'require "action_cable_client"; client = ActionCableClient.new("ws://example.test/cable", "RoomChannel", false); received = nil; client.disconnected { |code, reason| received = [code, reason] }; client._disconnected_callback.call(1000, "normal"); raise received.inspect unless received == [1000, "normal"]; puts "disconnect callback args ok"' -> disconnect callback args ok

I also opened #41 to restore GitHub Actions/RuboCop for the repo, since missing CI was the blocker discussed here. Once that lands, this PR should have a path to real CI coverage too. Happy to help add a focused spec for the close code/reason behavior if that would make review easier.