[18.0][ADD] new module hr_work_entry_holidays_usability#1539
Open
[18.0][ADD] new module hr_work_entry_holidays_usability#1539
Conversation
4 tasks
Contributor
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Looks like a useful usability add-on. Clean scaffolding, proper dependency on hr_work_entry_usability.
Tests and runboat are currently failing though — this will need a fix before it can proceed. Once green, happy to re-review.
Member
Author
|
@alexey-pelykh thanks for the review! the tests are currently failing only because #1538 is not merged. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improve usability of time off work entries.
depends on #1538.