[19.0][MIG] report_py3o: Migration to 19.0#1132
Conversation
Replace README.md by README.rst (not finished)
Remove <data> in views Protect import of py3o libs Remove dep on base module Other small changes
Rename __openerp__.py to __manifest__.py
kopeyev
force-pushed
the
19.0-mig-report_py3o
branch
19 times, most recently
from
d72b1dd to
af7e4f6
Compare
There was a problem hiding this comment.
How do you deal with the [report_py3o] section of the Odoo conf file which contains the root_tmpl_path key ?
Shouldn't you have something like this ?https://github.com/OCA/queue/blob/d2a8e902eef111cee495e96bd8bc903155ba29ae/queue_job/jobrunner/__init__.py#L13
report_py3o/wizard/py3o_report.py
Outdated
| """Check if the path is a trusted path for py3o templates.""" | ||
| real_path = os.path.realpath(path) | ||
| root_path = tools.config.get_misc("report_py3o", "root_tmpl_path") | ||
| root_path = tools.config.get("root_tmpl_path") |
There was a problem hiding this comment.
Почему убрал? Должен читать секцию report_py3o и данные оттуда
There was a problem hiding this comment.
в 19.0 убрали misc/get_misc, поэтому заменил на tools.config.get("root_tmpl_path")
There was a problem hiding this comment.
I've also seen that get_misc was removed but there is no automatic mechanism to get the report_py3o section in tools.config. So apart from the tests where you 'artificially' put root_tmpl_path directly into tools.config it won't work.
There was a problem hiding this comment.
тогда добавь реализацию, похожую на это https://github.com/OCA/queue/blob/d2a8e902eef111cee495e96bd8bc903155ba29ae/queue_job/jobrunner/__init__.py#L13
Как glitchov предложил
kopeyev
force-pushed
the
19.0-mig-report_py3o
branch
5 times, most recently
from
92af02a to
62ca952
Compare
kopeyev
force-pushed
the
19.0-mig-report_py3o
branch
from
62ca952 to
c4731ee
Compare
20 participants
No description provided.