Conversation
guewen
force-pushed
the
18.0-mig-auth_saml_environment
branch
2 times, most recently
from
9792c6d to
3b02656
Compare
|
Hello @guewen , thanks for the migration. Since last versions we ask people to merge/squash administrative & translation commits:
If would be great if you can have a look at it. It decreases the noise on the commits. |
leemannd
left a comment
leemannd
left a comment
There was a problem hiding this comment.
Technical work is good.
Nitpicking on the administrative/translations commits
Restore the usage of the form view by dropping the required condition on binary fields that are readonly. Those fields became mandatory after OCA/server-auth#342 but the module auth_saml_environment offer to use paths as a alternative config option for binaries thus those fields can be empty.
The base module already returns []
guewen
force-pushed
the
18.0-mig-auth_saml_environment
branch
from
3b02656 to
a6e016e
Compare
done |
|
/ocabot migration auth_saml_environment |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-256-by-yvaucher-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
7 participants
Migration of
auth_saml_environment, done with https://github.com/OCA/odoo-module-migratorThire is an additional commit worth noting: 81e9e74 I removed the override because the base method of
auth_samlalready returns the same value (an empty list).