-
-
Notifications
You must be signed in to change notification settings - Fork 726
[15.0][ADD] website_form_partner_specific_user_account #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 15.0
Are you sure you want to change the base?
Conversation
016567c to
bb53c4a
Compare
bb53c4a to
2fe3811
Compare
5f71b73 to
0972ad5
Compare
0972ad5 to
83a6152
Compare
83a6152 to
e7bfee9
Compare
yostashiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AungKoKoLin1997 Would you update tests as well?
e7bfee9 to
03f201a
Compare
..._form_partner_specific_user_account/tests/test_website_form_partner_specific_user_account.py
Outdated
Show resolved
Hide resolved
..._form_partner_specific_user_account/tests/test_website_form_partner_specific_user_account.py
Outdated
Show resolved
Hide resolved
..._form_partner_specific_user_account/tests/test_website_form_partner_specific_user_account.py
Show resolved
Hide resolved
..._form_partner_specific_user_account/tests/test_website_form_partner_specific_user_account.py
Outdated
Show resolved
Hide resolved
03f201a to
5658bfb
Compare
|
|
||
| self.assertTrue(website_partner) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be like this?
| self.assertTrue(website_partner) | |
| self.assertTrue(website_partner) | |
| self.assertNotEqual(website_partner, original) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It would be good to make sure the new partner is created even thought there is website_2 condition in the website_partner searching.
5658bfb to
572abda
Compare
yostashiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review. LTGM.
This module is intended for use when the “Specific User Account” setting is enabled on a website.
It assigns the current website to partners used by website forms and ensures partner lookup and assignment are restricted to that website.
In standard Odoo, partner resolution from website forms does not consider the current website. When “Specific User Account” is enabled, this may result in a partner from another website being assigned if the same email address exists across multiple websites.
This module addresses this issue.
@qrtl QT6278