Pass C runtime that is linked with libcob in cobc for MSVC - #300
Open
oguzcankirmemis wants to merge 2 commits into
Open
Pass C runtime that is linked with libcob in cobc for MSVC#300oguzcankirmemis wants to merge 2 commits into
oguzcankirmemis wants to merge 2 commits into
Conversation
The current version does not ensure that the C runtimes of libcob and compiled target match. This can cause undefined behavior if there is a communication between the two C runtimes, like passing a FILE pointer from one to another. This also fixes the issue with two failing CI tests (CBL_GC_HOSTED, COB_SIGNAL_REGIME) that is otherwise failing in MSVC builds. Signed-off-by: Oguzcan Kirmemis <oguzcan.kirmemis@gmail.com>
Collaborator
|
the commit needs to be split - I'll to the cobc part upstream now |
Update changelog to reflect changes in cobc.c regarding new macros for Windows builds.
Collaborator
|
Non-CI parts merged in SVN @ 5691. Thanks for this PR ! |
Collaborator
|
Can be closed as soon as the CI parts are checked in, ideally with a clean merge :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version does not ensure that the C runtimes of libcob and compiled target match. This can cause undefined behavior if there is a communication between the two C runtimes, like passing a FILE pointer from one to another. This also fixes the issue with two failing CI tests (CBL_GC_HOSTED, COB_SIGNAL_REGIME) that is otherwise failing in MSVC builds.