Skip to content

Conversation

@Rx1513
Copy link

@Rx1513 Rx1513 commented Dec 3, 2025

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/8146

Describe changes:

  • Move error logging from util-mpm-hs to util-hyperscan to reuse it in util-spm-hs.
  • Move include of hyperscan header file to util-hyperscan.
  • Add missing deallocators.

Provide values to any of the below to override the defaults.

  • To use a Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=

Rx1513 added 2 commits December 3, 2025 09:32
Move error logging from util-mpm-hs to reuse it in util-spm-hs as it
has proper hs_compile error handling.
Add missing deallocator for expr when hs_compile fails.
@Rx1513 Rx1513 requested a review from victorjulien as a code owner December 3, 2025 06:45
Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work, looking good.
Still needs an improvement in the commit message...

CI : running...
Code : good
Commits segmentation : ok
Commit messages : ⚠️ could you please put the redmine ticket number in the commit message ? see https://docs.suricata.io/en/latest/devguide/contributing/code-submission-process.html#commits
Git ID set : looks fine for me
CLA : you already contributed
Doc update : not needed
Redmine ticket : ok
Rustfmt : no rust
Tests : do you manage to reproduce with a SV test ?
Dependencies added: none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants