GDS Client: create a new .pfx (fresh key pair) from a .der certificate - #751
Merged
Conversation
Add a 'New Key Pair (.pfx)' action to ApplicationCertificateControl that clones the subject, application URI(s) and domain names (SAN) of the currently loaded certificate and generates a new RSA key pair, exporting the result as a .pfx. This enables turning a public-only (.der) certificate into a usable .pfx. Closes #742 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The GDS Client could load a public-only certificate (e.g. from a
.derfile), but there was no clear end-to-end way to turn it into a usable.pfxthat carries a private key. Temporary certificates were only created as a side effect of some CSR paths.This adds a "New Key Pair (.pfx)" action to
ApplicationCertificateControlthat clones the identity of the currently loaded certificate and generates a fresh key pair for it:.pfxvia a save dialog, encrypted with the password from the existing Private Key Password box when one is provided.The button is wired into the existing buttons panel in the designer alongside Request New / Apply Changes.
Related Issues
Types of changes
Checklist
Further comments
This is a WinForms sample UI change; the project builds cleanly (0 errors) but the button flow itself was not runtime-verified, so a quick manual smoke test in the GDS Client is worthwhile. The new certificate reuses the SAN from the source certificate rather than re-deriving domains from application configuration, keeping the clone faithful to the loaded
.der.