Conversation
Corrected ConfigureSumoLibraryPath() to check exeDir/CommonLib/libsumo/bin instead of exeDir/libsumo/bin. This fixes DLL discovery when TrafficLayer.exe is placed directly in the repo root directory. The fix ensures all three deployment scenarios work correctly: - repo/build/TrafficLayer.exe (via parent traversal) - repo/TrafficLayer/x64/Debug|Release/TrafficLayer.exe (via parent traversal) - repo/TrafficLayer.exe (via direct check) Related to #83
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed ConfigureSumoLibraryPath() in mainTrafficLayer.cpp to correctly discover SUMO DLLs when TrafficLayer.exe is placed directly in the repo root directory. Changed the direct check from exeDir / "libsumo" / "bin" to exeDir / "CommonLib" / "libsumo" / "bin".
Related Issues / Tasks
Closes #83
Type of Change
Affected Modules / Components
Test Cases
Tested all three deployment scenarios:
Environment
Only fill in the tools used for testing this PR:
Checklist
Additional Notes (optional)
The fix ensures the parent directory traversal logic works correctly for all scenarios by adding an explicit check for the direct CommonLib path in the exe directory first.