fix: resolve pipenv dependency installation failure and stale apt index in Dockerfiles#48
Open
piyush140104 wants to merge 1 commit into
Open
Conversation
…e in waf_modsec Dockerfile
fzipi
reviewed
May 10, 2026
| @@ -1,5 +1,5 @@ | |||
| FROM owasp/modsecurity-crs | |||
| RUN apt install -y wget nano curl | |||
| RUN apt-get update && apt-get install -y wget nano curl | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| RUN apt-get update && apt-get install -y wget nano curl | |
| RUN apt-get update -qq && apt-get install -qq --no-install-recommends --no-install-suggests -y wget nano curl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue: #47
Reviewers
@adrianwinckles
What this PR fixes
COPY ./ /appbeforeRUN pipenv installso thePipfileis present when dependencies are installed.apt-get update &&beforeapt-get installso the package index is fresh before installing packages.