Skip to content

Fix float parsing of ISO section codes like 5.10 #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VivekGhantiwala wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix float parsing of ISO section codes like 5.10 #799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions application/utils/spreadsheet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,21 +58,15 @@ def read_spreadsheet(
"(remember, only numbered worksheets"
" will be processed by convention)" % wsh.title
)
records = wsh.get_all_records(
head=1,
numericise_ignore=list(
range(1, wsh.col_count)
), # Added numericise_ignore parameter
) # workaround because of https://github.com/burnash/gspread/issues/1007 # this will break if the column names are in any other line
rows = wsh.get_all_values()
headers = rows[0]
records = [dict(zip(headers, row)) for row in rows[1:]]
toyaml = yaml.safe_load(yaml.safe_dump(records))
result[wsh.title] = toyaml
elif not parse_numbered_only:
records = wsh.get_all_records(
head=1,
numericise_ignore=list(
range(1, wsh.col_count)
), # Added numericise_ignore parameter -- DO NOT make this 'all', gspread has a bug
) # workaround because of https://github.com/burnash/gspread/issues/1007 # this will break if the column names are in any other line
rows = wsh.get_all_values()
headers = rows[0]
records = [dict(zip(headers, row)) for row in rows[1:]]
toyaml = yaml.safe_load(yaml.safe_dump(records))
result[wsh.title] = toyaml
except gspread.exceptions.APIError as ae:
Expand Down