[wpmlpb-787] Elementor v4: move e-component to PHP so we can add an integration class

[dgwatkins]

It is safe to deploy because we do class_exists( $class_or_instance )

https://onthegosystems.myjetbrains.com/youtrack/issue/wpmlpb-787/

[strategio]

@dgwatkins, sorry but this does not make sense to me. Since it's a hardcoded integration, why don't you just keep everything in the same place? (https://git.onthegosystems.com/glue-plugins/wpml/wpml-page-builders/-/merge_requests/369/)

[dgwatkins]

@strategio Yes, I could. Caveats?

• The transition period: I believe XML overrides hardcoded configs, if we remove the XML we need users to update. The gap should be ok since we only have partial support.
• Another thing is the type="post-ids". I was unsure if I can do that from a hardcoded config, but I can look into it.

[dgwatkins]

Let me move everything to PHP and I will call for review again @strategio

[dgwatkins]

I added the tag to merge-when-releasing

[strategio]

@dgwatkins, this is getting confusing because your change is different now, you are removing the config to automatically convert components IDs => Your PR description and your commit message does not reflect that... Please fix it!

Moreover, I would like to know why you are doing that?

With that config, component IDs are converted on the fly. Did you implement the same solution in your integration?

[dgwatkins]

@strategio Its a work in progress (I will call for review when its ready):

• yes, ill update the title of the PR before calling you
• because XML and PHP don't integrate. The XML configuration overrides the PHP configuration and you requested that I remove the integration class from XML. So I had to remove everything
• yes, of course: the on-the-fly conversion will happen in PHP

[dgwatkins]

@strategio The move is complete, but I still have to take care of your code review in gitlab.

[strategio]

@dgwatkins, I believe it's fine to remove the V4 beta config now.

But I think it's too early to remove the e-component config, WPML 4.9.3 is still in a bucket phase.

Is there a problem if we keep it for longer?

[dgwatkins]

Is there a problem if we keep it for longer?

@strategio the only problem will be for 4.9.3 users trying to translate e-component overridden properties.

[dgwatkins]

@strategio we could wait for the announcement, I haven't seen it yet.

Maybe even mention it in the announcement?

[strategio]

@dgwatkins, I suggest waiting for WPML 4.9.3 to be released to 100% users (it should not be long). Then deploy that change and close our errata.