Skip to content

Vinay K Costs Graph#5276

Open
Vinay944924 wants to merge 5 commits into
developmentfrom
vinay_k_costs_graph
Open

Vinay K Costs Graph#5276
Vinay944924 wants to merge 5 commits into
developmentfrom
vinay_k_costs_graph

Conversation

@Vinay944924

Copy link
Copy Markdown
Contributor

Description

Screenshot 2026-05-15 at 6 56 39 PM

Related PRS (if any):

This frontend PR is related to the development backend PR.

Main changes explained:

  • Enhanced Planned vs Actual Cost Visibility with variance and budget indicators

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to http://localhost:5173/bmdashboard/totalconstructionsummary -> Financials Tracking → Planned vs Actual Costs
  6. Verify the budget indicators and variance for Planned vs Actual Cost

Screenshots or videos of changes:

Task.mov

Note:

Include the information the reviewers need to know.

@netlify

netlify Bot commented May 16, 2026

Copy link
Copy Markdown

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit d1680ea
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6a1bccf20c29980008a01bc3
😎 Deploy Preview https://deploy-preview-5276--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@kunchalasireesha kunchalasireesha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Vinay,

Tested Financials Tracking → Planned vs Actual Costs for budget indicators and variance.

Currently blocked by an API issue — the page shows:
“Error: Failed to load project cost data”

From the logs, the predictions API request appears to be malformed due to URL construction:
http://localhost:4500/api//project/1/predictions
(double / before project).

It looks like APIEndpoint already includes /api, and the request path may be adding an extra /. Because of this, I’m unable to verify the Planned vs Actual Cost calculations/variance until the API issue is resolved

Screenshot 2026-05-22 at 3 40 12 PM

@DeepighaJ DeepighaJ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting npm error while npm install

Image

@sonarqubecloud

Copy link
Copy Markdown

@DeepighaJ DeepighaJ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Checked out to current branch and test PR locally.
  • The variance and budget indicators are displayed as expected in both light and dark modes.
  • However when filtering the categories the Variance & budget indicator displays Total Variance instead of filtered category variance. If this is the expected behavior then good to go.
Image Image Image

@HemanthNidamanuru HemanthNidamanuru left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Vinay,

I tested this locally following the steps provided and found 1 issue:

The graph is not loading in the Financials Tracking > Planned vs Actual Costs section.
I can see from the backend logs that the API is being called with the Project ID but "No tools found for project" and Total tools cost: 0, which seems to be causing the graph to not render.

Image Image

@amaresh2001 amaresh2001 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on vinay_k_costs_graph.

Testing:

  • Variance and Budget Indicators section displays correctly, showing Total Variance, Planned/Actual/Variance breakdown, and "OVER BUDGET" and "UNDER BUDGET" labels.
  • Project dropdown updates the bar chart and variance indicators correctly.
  • Category dropdown (Overall, Labor, Materials, Equipment) updates the numbers correctly.
  • Dark mode is fully supported, variance table and indicators remain readable.

Issues:
"Planned Vs Actual Costs Tracking" line chart fails to load. The left side of the section displays "Error: Failed to load project cost data" instead of rendering the line chart (with Planned Cost, Actual Cost, and Predicted Cost lines).

Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants