Skip to content

Ogc 2845 diverse bugfixes pas#2319

Merged
cyrillkuettel merged 39 commits intomasterfrom
ogc-2845-diverse-bugfixes-pas
Jan 30, 2026
Merged

Ogc 2845 diverse bugfixes pas#2319
cyrillkuettel merged 39 commits intomasterfrom
ogc-2845-diverse-bugfixes-pas

Conversation

@cyrillkuettel
Copy link
Copy Markdown
Contributor

Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.

Commit message

Pas: Fixes various

TYPE: Bugfix
LINK: OGC-2845

Checklist

  • I have performed a self-review of my code

- Remove 'Plenary session (bulk)' link from commission president view
- Commission presidents now only see 'New Attendence' and 'Commission
meeting (bulk)'
- Add permission checks to add_plenary_attendence and
edit_plenary_bulk_attendence views
- Prevent direct URL access to plenary bulk endpoints for non-admins
@linear
Copy link
Copy Markdown

linear Bot commented Jan 28, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 34.72222% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.32%. Comparing base (ae5b7a9) to head (afe920c).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/onegov/pas/views/attendence.py 16.66% 35 Missing ⚠️
src/onegov/pas/views/commission.py 26.66% 11 Missing ⚠️
src/onegov/pas/custom.py 88.88% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/pas/forms/attendence.py 78.80% <100.00%> (+0.25%) ⬆️
src/onegov/pas/layouts/attendence.py 97.91% <100.00%> (+0.09%) ⬆️
src/onegov/translator_directory/layout.py 93.35% <ø> (ø)
src/onegov/pas/custom.py 95.16% <88.88%> (-1.27%) ⬇️
src/onegov/pas/views/commission.py 83.47% <26.66%> (-7.79%) ⬇️
src/onegov/pas/views/attendence.py 43.20% <16.66%> (-5.61%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae5b7a9...afe920c. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cyrillkuettel and others added 25 commits January 28, 2026 20:04
- Commission presidents can no longer select 'plenary' meeting type
Allows users to create new translators where they might not
know the social sec. number beforehand.

TYPE: Bugfix
LINK: OGC-2924
TYPE: Feature
LINK: PRO-1474
TYPE: Feature
LINK: OGC-1663
TYPE: Feature
LINK: OGC-2933
TYPE: Bugfix
LINK: OGC-2939
cyrillkuettel and others added 11 commits January 29, 2026 10:53
…for different search weights

This makes organizer name more relevant than the organizations bank account

TYPE: Feature
LINK: None
- Remove 'Plenary session (bulk)' link from commission president view
- Commission presidents now only see 'New Attendence' and 'Commission
meeting (bulk)'
- Add permission checks to add_plenary_attendence and
edit_plenary_bulk_attendence views
- Prevent direct URL access to plenary bulk endpoints for non-admins
@cyrillkuettel cyrillkuettel merged commit 58d94c5 into master Jan 30, 2026
15 of 16 checks passed
@cyrillkuettel cyrillkuettel deleted the ogc-2845-diverse-bugfixes-pas branch January 30, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants