[projmgr] Validate component Cbundle conflicts (ignore Cvendor)#2401
Merged
brondani merged 9 commits intoOpen-CMSIS-Pack:mainfrom Mar 18, 2026
Merged
[projmgr] Validate component Cbundle conflicts (ignore Cvendor)#2401brondani merged 9 commits intoOpen-CMSIS-Pack:mainfrom
brondani merged 9 commits intoOpen-CMSIS-Pack:mainfrom
Conversation
5 tasks
brondani
reviewed
Mar 18, 2026
brondani
approved these changes
Mar 18, 2026
Collaborator
brondani
left a comment
There was a problem hiding this comment.
LGTM.
Please update the PR description.
Contributor
Author
|
@brondani The PR description has been updated. Please merge this PR, as even with write permission, I do not have the right to merge it. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2401 +/- ##
==========================================
+ Coverage 64.66% 64.69% +0.02%
==========================================
Files 145 145
Lines 26092 26113 +21
Branches 15745 15761 +16
==========================================
+ Hits 16872 16893 +21
Misses 7068 7068
Partials 2152 2152
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jthuangarm
added a commit
to Open-CMSIS-Pack/cmsis-toolbox
that referenced
this pull request
Mar 18, 2026
Clarify rules of multiple component declaration for components - Related to Open-CMSIS-Pack/devtools#2401 ## Checklist <!-- Put an `x` in the boxes. All tasks must be completed and boxes checked before merging. --> - [x] 🤖 This change is covered by unit tests (if applicable). - [x] 🤹 Manual testing has been performed (if necessary). - [x] 🛡️ Security impacts have been considered (if relevant). - [x] 📖 Documentation updates are complete (if required). - [x] 🧠 Third-party dependencies and TPIP updated (if required). --------- Co-authored-by: Joachim Krech <8290187+jkrech@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DuplicateComponentsunit test, as it is important to clear error message afterwards for different use cases.Cbundleexists, the sameCclassmust belong to the sameCbundle, while ignoringCvendor. Expected error message from TestProject2 is as follows: