Tiny performance tuning in CalcAuth#1217
Merged
Merged
Conversation
Tiny performance tuning: `llListFindList(g_lBlock,[sID])` is executed in any cases of the if under any circumstances. In some scenarios it is executed twice - so the line if(llListFindList(g_lBlock,[sID])!=-1)return CMD_BLOCKED; could also be executed prior the if, which provides a tiny bit of performance e.g. in cases neither nor owner click the collar.
Contributor
|
Looks correct, if kID is blocked it will always return CMD_BLOCKED irrespective of other conditions, so it can be move up. Still should be given sanity testing, not that the performance will ever be noted, but the logic is clearer. |
NikkiLacrima
reviewed
Jul 3, 2026
NikkiLacrima
left a comment
NikkiLacrima
left a comment
Contributor
There was a problem hiding this comment.
Looks good, approved.
NikkiLacrima
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny performance tuning:
llListFindList(g_lBlock,[sID])is executed in any cases of the if under any circumstances. In some scenarios it is executed twice - so the lineif(llListFindList(g_lBlock,[sID])!=-1)return CMD_BLOCKED;could also be executed prior the if, which provides a tiny bit of performance e.g. in cases somebody being neither wearer nor owner clicks the collar.