Add reference counting#2554
Merged
wixoaGit merged 7 commits intoOpenDreamProject:masterfrom May 7, 2026
Merged
Conversation
boring-cyborg
Bot
added
Compiler
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
# Conflicts: # OpenDreamRuntime/Objects/Types/DreamObjectMovable.cs # OpenDreamRuntime/Objects/Types/DreamObjectParticles.cs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
An inaccurate count led to not all locals being cleared on DMProcState disposal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now keep track of how many references every DreamObject has. Once it hits 0 we automatically delete the object, rather than depending/waiting on the .NET GC to collect it. DreamValue now has IDisposable so you can use
usingto automatically track a reference, and use[MustDisposeResource]to make it clear when a DreamValue reference will need to be tracked.I'm not a fan of the annoying bugs this will introduce and added development friction, but this puts us closer to BYOND behavior in a lot of ways and opens the door for some big optimizations we need to make.