Draft
Conversation
added 11 commits
February 28, 2021 12:45
|
Hey, i'm currently using the software to manage a server we're using. |
Member
|
Testing with Vanilla factorio:
Testing with Mods (all Angel's mods):
Log: |
Member
Author
|
@C0bai please visit our discord server: https://discord.gg/SB647WmSbU |
Member
Author
|
This looks like there is still plenty of work. I have to figure out how I can add the mod support. This might be complicated and complex. Regarding the error message, I have created a new issue #287 since it happens on other views as well. I will fix it separately because it should not wait until the map generator is finished. |
Member
Author
|
I'm not sure how we want to support modded ores. I have downloaded https://mods.factorio.com/mod/bobores and tried to figure out where I can get the information of the added ores. Unfortunately, they're added with in a LUA file - one file for each ore. This means we have to generic parse all LUA files. @knoxfighter do you have any idea how we can handle it? In the end it's always possible to either not have a map generator or only for non-modded saves. |
Member
Yes, we can add LUA and read out the Mods by ourselves. I have some experience with that, cause of my factorio intellij plugin. For now i would say, we should ignore mods. Just add a message on top, that with mods, that alter ores, the generation is broken. I will look into that sometime. Most mods will work, only some overhauls like Bobs, Angels or Industrial Revolution will break it. |
Contributor
|
To deal with mods it's probably a lot easier to just have factorio do the heavy lifting:
|
Member
|
It is possible to get all data information with the startup parameter: |
# Conflicts: # src/api/routes.go # ui/App/App.jsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The map generator replaces the possibility to create a save file with all possible settings you know from factorio.
Unfortunately there are some known issues related to the map template selection (default, island, death world, ... ).
I wasn't sure how to map certain values so the template selection doesn't match the ingame templates. Therefore I have added some todo comments.
Open todo: