Use lexemes so that list can be empty#5
Merged
martinsumner merged 5 commits intoopenriak-3.2from Dec 4, 2025
Merged
Conversation
As it is a string to be split, already must be a string
the `to_string/1` function appears to have use for converting a datatype back to a string. However, it is also used to convert the default value as read to a string to add to the default section of the file. Most to_string/1 clauses handle this by checking if the input is a list - and don't do anything with a list ... but a list will be a list, and a string! Changed this so that it cannot be a list of integers - then we assume a list of all integers is in fact a string which doesn't need conversion, and not a list that needs conversion
WarpEngineer
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4