revert(cli): posthog feature flags + fast_provision experiment (#3366)#3370
Closed
revert(cli): posthog feature flags + fast_provision experiment (#3366)#3370
Conversation
…3366)" This reverts commit f7652de. Rolling back on request. Net effect on users: * No more /decide fetch at startup — the up-to-1.5s cold-cache path is gone for everyone. * `fast_provision` experiment is off. Users who did NOT pass --beta/--fast get the old provisioning defaults (no tarball/images) instead of the test-variant defaults. * The persistent install-id file at ~/.config/spawn/.telemetry-id continues to exist — telemetry.ts is restored to its pre-#3366 inline loadOrCreateUserId() that writes the same path, so existing users keep their PostHog identity. Also reverts the follow-up review fixes in that PR (pick/feedback fast-path skip and real SWR) since they only exist because the feature flag system existed. The feature-flags-cache.json left on disk by any user who ran the shipped version becomes dead data; it's ignored when the module is gone. No migration needed.
Member
Author
|
Closing per request — not rolling back #3366 after all. Keeping the feature-flag plumbing + |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rollback of #3366 per request.
Reverts the squash commit
f7652de4(which included my follow-up review fixes from #3366 — pick/feedback fast-path skip and real SWR). Those fixes only existed because the feature-flag module existed, so they go with it.Net effect on users
/decidefetch at startup — the up-to-1.5s cold-cache path is gone for everyone.fast_provisionexperiment is off. Users who did not pass--beta/--fastrevert to the old provisioning defaults (no tarball/images by default) instead of the test-variant defaults.~/.config/spawn/.telemetry-idkeeps working —telemetry.tsis restored to its pre-feat(cli): posthog feature flags + fast_provision experiment #3366 inlineloadOrCreateUserId()that writes the same path, so existing users keep their PostHog identity.Notes
feature-flags-cache.jsonfiles left on disk by anyone who ran the shipped 1.0.23 become dead data. Harmless; no migration needed.packages/cli/change).fast_provisionexperiment is still live in the dashboard, disable it or drop its rollout to 0 % so the exposure events stop flowing.Test plan
bunx @biomejs/biome check src/— 0 errorsbun test— 2112 pass, 0 failFiled from Slack by SPA